Support for RC-28 USB encoder planned?

Feature Requests
182

That’s pretty cool, John.

If you can look at the code that Phil and Dawid are working on, perhaps you can make your controls compatible? wfview lets you assign actions in the USB Controller setup – you just need to make your controller identify and operate like one of the ones we have already.

–E
de W6EL

183

Its definitely there, maybe try a clean “pull” from gitlab?

~WRD0001.jpg

184 
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ git pull
Already up to date.
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ git stash
No local changes to save
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ git pull
Already up to date.
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ git status
On branch ecoder
Your branch is up to date with 'origin/ecoder'.

nothing to commit, working tree clean

dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ rm -rf ../build/
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ mkdir ../build
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ cd ../build/
dawszy@dawszy-XPS-13-9310:~/git/original/build$ qmake ../wfview/wfview.pro
Info: creating stash file /home/dawszy/git/original/build/.qmake.stash
make -j

same result
second approach:

dawszy@dawszy-XPS-13-9310:~/git/original$ rm -rf build/ wfview/
dawszy@dawszy-XPS-13-9310:~/git/original$ git clone git@gitlab.com:eliggett/wfview.git
Cloning into 'wfview'...
remote: Enumerating objects: 9856, done.
remote: Counting objects: 100% (416/416), done.
remote: Compressing objects: 100% (130/130), done.
remote: Total 9856 (delta 364), reused 286 (delta 286), pack-reused 9440
Receiving objects: 100% (9856/9856), 32.76 MiB | 11.35 MiB/s, done.
Resolving deltas: 100% (7117/7117), done.
dawszy@dawszy-XPS-13-9310:~/git/original$ git checkout ecoder
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
dawszy@dawszy-XPS-13-9310:~/git/original$ cd wfview/
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ git checkout ecoder
Branch 'ecoder' set up to track remote branch 'ecoder' from 'origin'.
Switched to a new branch 'ecoder'
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ mkdir ../build
dawszy@dawszy-XPS-13-9310:~/git/original/wfview$ cd ../build/
dawszy@dawszy-XPS-13-9310:~/git/original/build$ qmake ../wfview/wfview.pro
Info: creating stash file /home/dawszy/git/original/build/.qmake.stash

same result:

../wfview/usbcontroller.cpp: In member function ‘void usbController::run()’:
../wfview/usbcontroller.cpp:211:72: error: ‘usbMutex’ was not declared in this scope; did you mean ‘QMutex’?
  211 |             emit newDevice(usbDevice, buttonList, knobList, commands, &usbMutex); // Let the UI know we have a new controller
      |                                                                        ^~~~~~~~
      |                                                                        QMutex
make: *** [Makefile:1382: usbcontroller.o] Error 1
make: *** Waiting for unfinished jobs....
185

Same here.

../wfview/usbcontroller.cpp: In member function ‘void usbController::run()’:
../wfview/usbcontroller.cpp:211:72: error: ‘usbMutex’ was not declared in this scope; did you mean ‘QMutex’?
  211 |           emit newDevice(usbDevice, buttonList, knobList, commands, &usbMutex); // Let the UI know we have a new controller
      |                                                                      ^~~~~~~~
      |

I also get the HID_API_VERSION errors. I think we have those fixed in the master branch though.

–E
de W6EL

186

Yes sorry you are quite correct, I am using Qt6 so that code is commented out for me, fixed now.

I have also merged master into it.

187 
../wfview/usbcontroller.cpp: In member function ‘void usbController::run()’:
../wfview/usbcontroller.cpp:234:71: error: cannot convert ‘QMutex**’ to ‘QMutex*’
  234 |             emit newDevice(usbDevice, buttonList, knobList, commands, &mutex); // Let the UI know we have a new controller
      |                                                                       ^~~~~~
      |                                                                       |
188

I think that mutex is declared in wfview.h but not usbcontroller.h

–E

189

Yes I just spotted that as well, it’s a problem when I can’t test the code… Should be OK now :slight_smile:

190

It is still NOT OK :slight_smile:

191

Did it compile though?

192

No, still the same error:)

193

Helps if I press ‘push’… Try now!

1 Like
194

So, it is now stable.
VFO works as it was working before.
PTT also.
BUT :wink:
knobs assigned to AF, RF and TX are behaving strange, I turn knob of AF a lot and suddenly TX slider on main screen goes totally down…
There is no “expected” connection between knobs and sliders;)
Debug log data looks correct and as expected.

195

Can you post the log when moving knobs log as I suspect that I know what that is?

196

Ah small correction.
knob 1 should be knob 3.
Let me test more…

197

When I move TX knob…
TX slider is either UP or DOWN there is no point in between while in logs:

2023-02-10 19:22:48.019 INF usbcontrol: Sending Knob: 2 Command: 0 :Value: 253
2023-02-10 19:23:45.852 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:45.953 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:46.054 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:46.155 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:46.256 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:46.356 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:46.558 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:46.659 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:46.759 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:46.860 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:46.961 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:47.062 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:47.968 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:48.068 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:48.270 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:48.371 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:48.572 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:48.774 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:48.874 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:48.975 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:49.076 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:49.882 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:23:49.983 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:23:50.185 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:23:51.192 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:51.394 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:51.696 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:51.998 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:52.804 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:52.905 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:53.106 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:53.308 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:53.409 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254
2023-02-10 19:23:53.509 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:23:54.416 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:23:55.724 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:23:57.639 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:23:59.451 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255
2023-02-10 19:24:00.659 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:24:00.962 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
198

This:

2023-02-10 19:25:50.686 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:25:52.903 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:25:55.120 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:25:57.337 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1
2023-02-10 19:25:57.741 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1

is causing TX slider to go total DOWN from UP (no point in between) and more… the direction is also an issue. I am turning RIGHT - so it should go UP not DOWN… :wink:

199

Can you try with what I have just updated? It won’t work but I have added another field to the log to show the raw value.

200 
2023-02-10 19:28:54.672 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:28:55.680 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:28:56.486 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:28:57.291 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:28:57.997 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:28:58.803 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:28:59.710 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:00.314 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:01.121 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:01.927 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:02.632 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:04.647 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:05.454 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:06.361 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:07.167 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:07.872 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:08.679 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:09.486 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:10.191 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:10.292 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:10.997 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:13.416 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:14.726 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:15.331 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:16.036 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:16.641 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:18.354 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:18.354 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:50.489 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 2 Raw value: 2
2023-02-10 19:29:50.590 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 4 Raw value: 4
2023-02-10 19:29:50.691 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 2 Raw value: 2
2023-02-10 19:29:50.791 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 4 Raw value: 4
2023-02-10 19:29:50.892 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 3 Raw value: 3
2023-02-10 19:29:50.993 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 2 Raw value: 2
2023-02-10 19:29:51.094 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 4 Raw value: 4
2023-02-10 19:29:51.195 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 3 Raw value: 3
2023-02-10 19:29:51.296 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 2 Raw value: 2
2023-02-10 19:29:51.397 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 1 Raw value: 1
2023-02-10 19:29:52.709 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:52.810 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254 Raw value: -2
2023-02-10 19:29:52.910 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 253 Raw value: -3
2023-02-10 19:29:53.011 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:53.112 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 252 Raw value: -4
2023-02-10 19:29:53.212 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 252 Raw value: -4
2023-02-10 19:29:53.313 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 255 Raw value: -1
2023-02-10 19:29:53.414 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 252 Raw value: -4
2023-02-10 19:29:53.515 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 253 Raw value: -3
2023-02-10 19:29:53.616 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254 Raw value: -2
2023-02-10 19:29:53.717 INF usbcontrol: Sending Knob: 3 Command: 0 :Value: 254 Raw value: -2

it looks here its ok.

when I turn right its positive when left its negative

201

OK try it now. That “should” be correct :slight_smile: